Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncation long text on profile screen #18038

Merged
merged 3 commits into from Jul 5, 2022
Merged

Conversation

Link2Twenty
Copy link
Contributor

@Link2Twenty Link2Twenty commented Jul 5, 2022

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

When a string becomes too long for the screen truncate it with ellipse rather than breaking the site

Related Tickets & Documents

https://dev.to/wjplatformer/whats-wrong-foremdev-2-e89

QA Instructions, Screenshots, Recordings

Before:
Before truncation

After:
after truncation

UI accessibility concerns?

N/A

Added/updated tests?

  • Yes
  • No, and this is why: visual change only
  • I need help with writing tests

[optional] What gif best describes this PR or how it makes you feel?

encanto bruno with bucket on head

@Link2Twenty Link2Twenty requested review from a team, Ridhwana and aitchiss and removed request for a team July 5, 2022 12:18
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

Copy link

@Wjplatformer Wjplatformer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the overflow hidden :). (Also how'd you manage to navigate through the scripts of such a big project?)

Copy link
Contributor

@aitchiss aitchiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🔥 Thank you so much for this fix!

Copy link
Contributor

@fdocr fdocr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this fix @Link2Twenty! 🚀

@fdocr fdocr merged commit 4489b9a into forem:main Jul 5, 2022
@Link2Twenty Link2Twenty deleted the patch-2 branch July 6, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants