Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crayon styles to c-color-picker #18178

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

Link2Twenty
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature (maybe?)
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Update the colour picker styles to bring them inline with crayons

Related Tickets & Documents

closes #18130

QA Instructions, Screenshots, Recordings

The colour picker should now look like this

new colour picker

You can find it in settings under branding

UI accessibility concerns?

Don't think so

Added/updated tests?

  • Yes
  • No, and this is why: not a functionality change
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

Fairy magic

@Link2Twenty Link2Twenty requested a review from a team as a code owner July 20, 2022 09:20
@Link2Twenty Link2Twenty requested review from fdocr and aitchiss and removed request for a team July 20, 2022 09:20
@github-actions
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

Copy link
Contributor

@aitchiss aitchiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for this ✨

@aitchiss
Copy link
Contributor

(I restarted the failed build job as it seems to be unrelated flakiness)

@Ridhwana
Copy link
Contributor

Thanks for this @Link2Twenty

@Ridhwana Ridhwana merged commit 1162ddb into forem:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring Crayons to colour picker
3 participants