Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove featured_number from articles table #18514

Merged
merged 1 commit into from Sep 29, 2022

Conversation

fdocr
Copy link
Contributor

@fdocr fdocr commented Sep 28, 2022

What type of PR is this? (check all applicable)

  • Refactor
  • Optimization

Description

Follow up PR to #18510 to actually remove the column from the articles table.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

App should continue to work locally

UI accessibility concerns?

N/A

Added/updated tests?

  • No, and this is why: Tests were already updated when feature was removed

[Forem core team only] How will this change be communicated?

  • This change does not need to be communicated, and this is why not: Removal of functionality was already shared with internal teams

[optional] What gif best describes this PR or how it makes you feel?

and it's gone

@fdocr fdocr marked this pull request as ready for review September 28, 2022 17:19
@fdocr fdocr requested review from a team as code owners September 28, 2022 17:19
@fdocr fdocr requested review from maestromac, jaw6 and Ridhwana and removed request for a team September 28, 2022 17:19
Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Ridhwana Ridhwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@fdocr fdocr merged commit 3b575ac into main Sep 29, 2022
@fdocr fdocr deleted the fdocr/remove-featured-number-from-articles-table branch September 29, 2022 21:07
jaw6 added a commit that referenced this pull request Oct 3, 2022
…_tracking_rollup

* origin/main:
  Remove featured_number from articles table (#18514)
  Snackbar error message in comments image upload (#18504)
  Restore DisplayAd search (#18511)
  Update strong_migrations to version 1.3.1 (#18516)
  Refactor: no need to pass through the ahoy event name dynamically. (#18498)
  Remove featured number usage from articles (#18510)
  [ruby] Update sidekiq: 6.5.6 → 6.5.7 (patch) (#18507)
  Update recaptcha to version 5.12.3 (#18506)
  Update octokit to version 5.6.1 (#18505)
  Feed experiment for 09-26-2022 (#18501)
  Update all Yarn dependencies (2022-09-26) (#18497)
TERNOX pushed a commit to TERNOX/forem-bezmir that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove featured_number from application
4 participants