Fix the org post count issue #19503

aneshodza · 2023-05-19T10:41:29Z

What type of PR is this? (check all applicable)

Description

This pull request is just here to fix #19456. I added a regression spec and also a spec to check if the correct amount is displayed at all. The regression spec should be enough, but I'm happy to write more if that's needed.

Related Tickets & Documents

Related Issue Org page showing wrong number of posts. #19456
Closes Org page showing wrong number of posts. #19456

QA Instructions, Screenshots, Recordings

You can run the specific specs that I added by running following commands in your terminal:

bundle exec rspec spec/system/organization/user_views_an_organization_spec.rb:33
bundle exec rspec spec/system/organization/user_views_an_organization_spec.rb:37

The org page should now display the correct number:

UI accessibility concerns?

The accessibility shouldn't be impacted, even if this change is for the UI.

Added/updated tests?

Yes, added regression tests
No, and this is why: please replace this line with details on why tests
have not been included
I need help with writing tests

github-actions · 2023-05-19T10:41:43Z

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

app/views/organizations/_sidebar.html.erb

benhalpern

Needs to only show published, added the suggestion. Thanks for the PR!

jaw6

Thanks for submitting this! And thanks for fixing this bug! I have a couple of ideas of how we can make this work a bit better, but we're very much on the right track.

app/views/organizations/_sidebar.html.erb

jaw6 · 2023-05-19T12:48:05Z

spec/system/organization/user_views_an_organization_spec.rb

@@ -30,6 +30,16 @@
        end
      end

+      it "shows the right amount of articles in sidebar" do


I'm not sure we need two tests here — the other is a super-set of what's being tested here.

It just feels more intuitive to have the happy path and the edge-case tested in separate tests. If you think it's unnecessary I can remove it.

I think it's fine either way, but you could also condense them into a single example that tests different numbers of posts so it feels less arbitrary

spec/system/organization/user_views_an_organization_spec.rb

jaw6

Thanks again for fixing this bug! I think this is moving in the right direction, I noticed a couple of things that could make it even better.

spec/system/organization/user_views_an_organization_spec.rb

spec/models/organization_spec.rb

codecov · 2023-05-22T14:12:20Z

Codecov Report

Patch coverage: 100.00% and project coverage change: +26.90 🎉

Comparison is base (a5842bd) 58.60% compared to head (84fadfd) 85.51%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #19503       +/-   ##
===========================================
+ Coverage   58.60%   85.51%   +26.90%     
===========================================
  Files        1163     1155        -8     
  Lines       29593    25991     -3602     
  Branches     1887     1832       -55     
===========================================
+ Hits        17344    22225     +4881     
+ Misses      12062     3568     -8494     
- Partials      187      198       +11

Flag	Coverage Δ
cypress	`68.77% <ø> (-1.35%)`	⬇️
javascript	`68.77% <ø> (-1.35%)`	⬇️
ruby	`92.67% <100.00%> (+38.31%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
app/models/organization.rb	`98.03% <100.00%> (+2.03%)`	⬆️

... and 601 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

benhalpern · 2023-05-23T22:23:17Z

@maestromac any idea why the Build PR Image check is failing?

maestromac · 2023-05-24T14:04:58Z

@benhalpern Yup I am addressing that now

github-actions · 2023-05-24T15:15:40Z

Uffizzi Preview deployment-26473 was deleted.

filleduchaos

One more thing though - did you sign the CLA when you opened this PR? I was fairly sure I saw that you did, but it's not showing up in the PR checks 🤔 you can check whether you've signed or not here

aneshodza · 2023-05-24T17:05:37Z

One more thing though - did you sign the CLA when you opened this PR? I was fairly sure I saw that you did, but it's not showing up in the PR checks 🤔 you can check whether you've signed or not here

Yes, I did. It should be visible in the checks (it's the last one):

…tor_after_suggest * origin/main: Fix the org post count issue (#19503) Fix styling for long org promoted billboard (#19528) Revert Uffizzi refactors (#19526)

* origin/main: Manual Audience Segments API write endpoints (#19476) Refactoring onboarding (#19525) Fix the org post count issue (#19503) Fix styling for long org promoted billboard (#19528) Revert Uffizzi refactors (#19526)

* Fix the org post count issue * Add regression specs * Move things around and sort them better * Implement PR review * Revert accidental changes --------- Co-authored-by: Mac Siri <mac@forem.com>

Anes Hodza added 2 commits May 19, 2023 11:49

Fix the org post count issue

777c2be

Add regression specs

fdc341d

aneshodza requested a review from a team as a code owner May 19, 2023 10:41

aneshodza requested review from jaw6 and filleduchaos and removed request for a team May 19, 2023 10:41

aneshodza mentioned this pull request May 19, 2023

Org page showing wrong number of posts. #19456

Closed

benhalpern reviewed May 19, 2023

View reviewed changes

app/views/organizations/_sidebar.html.erb Outdated Show resolved Hide resolved

benhalpern requested changes May 19, 2023

View reviewed changes

jaw6 suggested changes May 19, 2023

View reviewed changes

Move things around and sort them better

463c8e2

aneshodza requested review from jaw6 and benhalpern May 19, 2023 14:04

jaw6 approved these changes May 22, 2023

View reviewed changes

spec/system/organization/user_views_an_organization_spec.rb Outdated Show resolved Hide resolved

spec/models/organization_spec.rb Outdated Show resolved Hide resolved

benhalpern approved these changes May 22, 2023

View reviewed changes

aneshodza had a problem deploying to uffizzi May 22, 2023 14:18 — with GitHub Actions Failure

Implement PR review

566788c

aneshodza requested a review from a team as a code owner May 23, 2023 19:55

aneshodza requested review from maestromac and removed request for a team May 23, 2023 19:55

aneshodza and others added 2 commits May 23, 2023 21:56

Merge branch 'main' into aneshodza/fix-org-post-count-19456

c52c8a9

Revert accidental changes

dabc2e8

aneshodza had a problem deploying to uffizzi May 23, 2023 22:13 — with GitHub Actions Failure

aneshodza had a problem deploying to uffizzi May 23, 2023 22:15 — with GitHub Actions Failure

Merge branch 'main' into aneshodza/fix-org-post-count-19456

84fadfd

filleduchaos approved these changes May 24, 2023

View reviewed changes

benhalpern merged commit 772f6cd into forem:main May 24, 2023
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the org post count issue #19503

Fix the org post count issue #19503

aneshodza commented May 19, 2023

github-actions bot commented May 19, 2023

benhalpern left a comment

jaw6 left a comment

jaw6 May 19, 2023

aneshodza May 19, 2023

filleduchaos May 19, 2023

jaw6 left a comment

codecov bot commented May 22, 2023 •

edited

Loading

benhalpern commented May 23, 2023

maestromac commented May 24, 2023

github-actions bot commented May 24, 2023 •

edited

Loading

filleduchaos left a comment

aneshodza commented May 24, 2023

Fix the org post count issue #19503

Fix the org post count issue #19503

Conversation

aneshodza commented May 19, 2023

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

Added/updated tests?

github-actions bot commented May 19, 2023

benhalpern left a comment

Choose a reason for hiding this comment

jaw6 left a comment

Choose a reason for hiding this comment

jaw6 May 19, 2023

Choose a reason for hiding this comment

aneshodza May 19, 2023

Choose a reason for hiding this comment

filleduchaos May 19, 2023

Choose a reason for hiding this comment

jaw6 left a comment

Choose a reason for hiding this comment

codecov bot commented May 22, 2023 • edited Loading

Codecov Report

benhalpern commented May 23, 2023

maestromac commented May 24, 2023

github-actions bot commented May 24, 2023 • edited Loading

filleduchaos left a comment

Choose a reason for hiding this comment

aneshodza commented May 24, 2023

codecov bot commented May 22, 2023 •

edited

Loading

github-actions bot commented May 24, 2023 •

edited

Loading