Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide linux/arm64 support. #19628

Closed
wants to merge 6 commits into from
Closed

Conversation

RedstoneWizard08
Copy link

@RedstoneWizard08 RedstoneWizard08 commented Jun 23, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This just allows support for linux/arm64 systems to run Forem.

This includes an open-sourced version of the quay.io/forem/ruby image, which was done by looking at the history of the image via docker history. It runs the same fedora OS and should have all the same packages.

Checklist:

  • Create Ruby image.
  • Add support in main image.
  • Update CI systems.
  • Validate everything works.

Related Tickets & Documents

#19626
#16765

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

How to test this:

  • Create a VM with an arm-based processor, either in the cloud provider or QEMU, and run this in docker.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Keyboard operability supported?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

For more info, check out the
Forem Accessibility Docs.

Added/updated tests?

  • Yes
  • No, and this is why: This is platform support, not any other features.
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@klardotsh
Copy link
Contributor

Copying what I posted in #19626:

Hey @RedstoneWizard08, thanks for the draft pull request and for reviving the branch - we really appreciate the enthusiasm! That said, we've already started this work internally and are doing last passes of testing on (1) a fully revised image that doesn't use Fedora as a base at all (making this draft hard to reconcile with the work ongoing), and (2) should come with ARM64 support out of the box. In general, we attach a Ready For Dev label to stuff that's ready for external contributors: in this case, we've attached Forem Team indicating we're tackling this one in-house. I converted the discussion to a ticket mostly for my own in-house tracking purposes, and this refs #19603 where you'll find further context about what has led to this bit of work coming onto my radar.

Again, thanks so much for opening a draft with the branch that held that work you'd already tackled, but no need to stress yourself (or burn your nights and weekends, or whatever) on this any further - I'm tackling this one as part of my day job here at Forem :)

For future such issues, look for that Ready For Dev label: those are open season and not things we're actively tackling (at that time) in-house, and I'm sure at some point, some platform and infrastructure related items might show up in that feed!

@klardotsh klardotsh closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide linux/arm64 architecture support with an open-source chain of images (eg. forem/ruby)
3 participants