Fix: Embedded articles unreadable in left sidebar billboards #20646 && #20735 #20752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morfenza
requested review from
lightalloy and
maestromac
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20752 ⚙️ Updating now by workflow run 8209782689. What is Uffizzi? Learn more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I've opened this PR but I'd like to start a discussion on the best approach. It took some time do isolate this behavior since I couldn't find a easy way do make the Billboard show an article, with the help of @danielmbrasil we were able to reproduce it. We erased all Billboards and created a new one using Factories setting its body_markdown with a link to a chosen article.
It also proved to be difficult to isolate the CSS responsible for it, since its tag is also used in other places, so I couldn't simply alter it, so I've chosen to create a specific tag for it.
Suggestions:
app/views/shared/_billboard.html.erbcreate a conditional forsidebar_left, trying to isolate the required billboard showing the articleRelated Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
What gif best describes this PR or how it makes you feel?