fix error that showed unapproved posts in sidebar #20776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PauloVilarinho
requested review from
lightalloy and
maestromac
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
PauloVilarinho
force-pushed
the
PauloVilarinho/fix-error-when-showing-unnapproved-posts-in-sidebar-20772
branch
from
4c2e622
to
dd5de88
Compare
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20776 ⚙️ Updating now by workflow run 8417018632. What is Uffizzi? Learn more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This fixes the error that was showing unapproved posts in the sidebar
Related Tickets & Documents
Closes #20772
QA Instructions, Screenshots, Recordings
Go to the admin and edit a Tag to change it to require approval
Now make this tag appear in the front page, to make this go to the Customization>Config menu and add the Tag you want to display here
Now if you go to the home page it should display only approved posts in this tag. If there is no post its probably because you don't have any approved posts. To approve a post go to the admin panel and go to the menu Content Manager>Posts
Go to the Posts that has the tag you selected and mark it as approved and save
After that this post should appear in the home page
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included