Resolve sidekiq warning #20805
Merged
Resolve sidekiq warning #20805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On running ./bin/startup, I noticed the warning: "WARN: `config.options[:key] = value` is deprecated, use `config[:key] = value`" pointing to forem/config/initializers/sidekiq.rb:29. This commit resolves that warning by removing `.options`
medwards1771
requested review from
maestromac and
lightalloy
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
maestromac
approved these changes
Mar 28, 2024
maestromac
reviewed
Mar 28, 2024
config/initializers/sidekiq.rb
Outdated
| @@ -26,7 +26,7 @@ def not_past_scheduled_time?(current_time) | |||
| # https://github.com/ondrejbartas/sidekiq-cron/issues/254 | |||
| # Sidekiq default is 5, we don't need it quite that often but would like it more than | |||
| # every 30 seconds which the gem defaults to | |||
| Sidekiq.options[:poll_interval] = 10 | |||
| Sidekiq[:poll_interval] = 10 | |||
There was a problem hiding this comment.
actually I think it would be better with
Suggested change
| Sidekiq[:poll_interval] = 10 | |
| config[:poll_interval] = 10 |
since it's already in this block and suggested by the dep warning
There was a problem hiding this comment.
good callout, ty. will update.
Sidekiq is set up in the block to be referenced as "config", see: Sidekiq.configure_server do |config|
|
Uffizzi Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
On running
/bin/startup, I noticed the warning:"WARN:
config.options[:key] = valueis deprecated, useconfig[:key] = value"pointing to forem/config/initializers/sidekiq.rb:29.
This commit resolves that warning by removing
.optionsQA Instructions, Screenshots, Recordings
Run the
bin/startupscript locally fromforem/forem:main. Notice the warning described above.Run the
bin/startupscript locally frommedwards1771/forem:resolve-sidekiq-warning-on-startup(or just make the change on your local copy of forem). Notice the warning disappear.Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
ActiveRecord::NoDatabaseErrorerrors when attempting to run the test suite locally withbin/rspecsince I don't have the database "Forem_test" and figured it would be faster to see the test suite run via CI.