Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust digest rate if recent clicks tracked #20838

Merged
merged 26 commits into from
Apr 10, 2024

Conversation

benhalpern
Copy link
Contributor

@benhalpern benhalpern commented Apr 4, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This adjusts digest emails to send one day more often if that user has recently clicked through on a prior digest email.

Related Tickets & Documents

app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Uffizzi Preview deployment-49905 was deleted.

spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
app/services/email_digest_article_collector.rb Outdated Show resolved Hide resolved
benhalpern and others added 10 commits April 8, 2024 14:18
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
The 'rebornix.Ruby' extension is deprecated. I replaced with the
'Shopify.ruby-lsp' extension since VSCode's Ruby docs pointed
users to ruby-lsp, see https://code.visualstudio.com/docs/languages/ruby.
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…l.erb (#20849)

Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
depfu bot and others added 2 commits April 10, 2024 09:37
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
spec/services/email_digest_article_collector_spec.rb Outdated Show resolved Hide resolved
@benhalpern benhalpern marked this pull request as ready for review April 10, 2024 13:58
@benhalpern benhalpern requested review from a team as code owners April 10, 2024 13:58
@benhalpern benhalpern requested review from maestromac and lightalloy and removed request for a team April 10, 2024 13:58
@benhalpern benhalpern merged commit 9b15329 into main Apr 10, 2024
32 checks passed
@benhalpern benhalpern deleted the ben/adjust-digest-rate-based-on-clicks branch April 10, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants