Generate multiarch Docker images #20848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgadelha
requested review from
maestromac and
lightalloy
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20848 ⚙️ Updating now by workflow run 8816192168. What is Uffizzi? Learn more! |
|
The crash on preview environment seems not to be related to the changes caused by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR moves the
build_containers.shscript to use Docker'sbuildx, with the multiarch image--platformflag enabledRelated Tickets & Documents
The
forem/ruby(build_base_ruby_image.sh) seems to be already using buildx/multiarch, so this PR changes thequay.io/forem/foremimagesQA Instructions, Screenshots, Recordings
It should be now possible to use
container-compose.ymlon ARM64 systems.Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.