Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlgoliaSearchable for User #20869

Merged
merged 13 commits into from Apr 19, 2024
Merged

Conversation

maestromac
Copy link
Member

@maestromac maestromac commented Apr 17, 2024

What type of PR is this? (check all applicable)

  • Feature

Description

Add options to turn on Algolia for user

Related Tickets & Documents

#20833

QA Instructions, Screenshots, Recordings

Added tests?

  • no, because they aren't needed

Added to documentation?

  • no documentation needed

[optional] Are there any post deployment tasks we need to perform?

n/a

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20869

⚙️ Updating now by workflow run 8741720072.

What is Uffizzi? Learn more!

config/sidekiq.yml Outdated Show resolved Hide resolved
@forem forem deleted a comment from github-actions bot Apr 17, 2024
@maestromac maestromac force-pushed the mac/feature/add-algolia-searchable-user branch from 3f7e8c8 to ec4d625 Compare April 17, 2024 17:17
@maestromac maestromac changed the title Add AlgoliaSearchable::SearchableUser Add AlgoliaSearchable for User Apr 17, 2024
@maestromac maestromac marked this pull request as ready for review April 17, 2024 18:15
@maestromac maestromac requested review from a team as code owners April 17, 2024 18:15
@maestromac maestromac requested review from lightalloy and benhalpern and removed request for a team April 17, 2024 18:15
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

@maestromac maestromac marked this pull request as draft April 18, 2024 14:47
@maestromac maestromac marked this pull request as ready for review April 18, 2024 15:27
@maestromac maestromac marked this pull request as draft April 18, 2024 16:11
@maestromac maestromac marked this pull request as ready for review April 18, 2024 16:18
@maestromac maestromac added this pull request to the merge queue Apr 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 19, 2024
@maestromac maestromac added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit d587ba9 Apr 19, 2024
32 checks passed
@maestromac maestromac deleted the mac/feature/add-algolia-searchable-user branch April 19, 2024 14:09
benhalpern pushed a commit that referenced this pull request Apr 19, 2024
* Add AlgoliaSearchable::SearchableUser

* Update spec

* Refactor

* Refactor

* Add more test

* Refactor

* Update seeder to clear Algolia index if it exist

* All Algolia directly in update_score

* Fix broken spec

* Remove new queue

* Account for more user statuses

* Remove unncessary test for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants