New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AlgoliaSearchable for User #20869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20869 ⚙️ Updating now by workflow run 8741720072. What is Uffizzi? Learn more! |
maestromac
commented
Apr 17, 2024
maestromac
force-pushed
the
mac/feature/add-algolia-searchable-user
branch
from
April 17, 2024 17:17
3f7e8c8
to
ec4d625
Compare
maestromac
changed the title
Add AlgoliaSearchable::SearchableUser
Add AlgoliaSearchable for User
Apr 17, 2024
maestromac
requested review from
lightalloy and
benhalpern
and removed request for
a team
April 17, 2024 18:15
benhalpern
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 19, 2024
benhalpern
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Add AlgoliaSearchable::SearchableUser * Update spec * Refactor * Refactor * Add more test * Refactor * Update seeder to clear Algolia index if it exist * All Algolia directly in update_score * Fix broken spec * Remove new queue * Account for more user statuses * Remove unncessary test for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add options to turn on Algolia for user
Related Tickets & Documents
#20833
QA Instructions, Screenshots, Recordings
Added tests?
Added to documentation?
[optional] Are there any post deployment tasks we need to perform?
n/a