Add search branding option #20902
Merged
Add search branding option #20902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhalpern
requested review from
maestromac and
lightalloy
and removed request for
a team
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20902 ⚙️ Updating now by workflow run 8880570223. What is Uffizzi? Learn more! |
maestromac
approved these changes
Apr 29, 2024
| @@ -148,6 +148,7 @@ class General < Base | |||
| setting :algolia_application_id, type: :string, default: ApplicationConfig["ALGOLIA_APPLICATION_ID"] | |||
| setting :algolia_api_key, type: :string, default: ApplicationConfig["ALGOLIA_API_KEY"] | |||
| setting :algolia_search_only_api_key, type: :string, default: ApplicationConfig["ALGOLIA_SEARCH_ONLY_API_KEY"] | |||
| setting :display_algolia_branding, type: :boolean, default: ApplicationConfig["ALGOLIA_DISPLAY_BRANDING"] == "true" | |||
There was a problem hiding this comment.
Suggested change
| setting :display_algolia_branding, type: :boolean, default: ApplicationConfig["ALGOLIA_DISPLAY_BRANDING"] == "true" | |
| setting :display_algolia_branding, type: :boolean, default: ApplicationConfig["ALGOLIA_DISPLAY_BRANDING"] |
The matching is unnecessary because this class will do automatic conversion and only "true" will be considered a true bool
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This adds the ability to turn on the "Powered by Algolia" if partnership is enabled. You can use Algolia search without this turned on, but if it is turned on, you see the Algolia logo.
Key part: When this is not turned on, nothing should be different.
Related Tickets & Documents