Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unable to Preview a Reply for a Comment Before Publishing it #20954

Conversation

joaoGabriel55
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

I can't preview a comment that I wrote before publishing it. There is nothing happen when I click the button.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

  1. Go to a post.
  2. Go to a comment and click reply.
  3. Write a reply.
  4. Click "preview" button.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Keyboard operability supported?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

For more info, check out the
Forem Accessibility Docs.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@joaoGabriel55 joaoGabriel55 requested a review from a team as a code owner May 13, 2024 20:50
@joaoGabriel55 joaoGabriel55 requested review from lightalloy and maestromac and removed request for a team May 13, 2024 20:50
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

Copy link
Contributor

github-actions bot commented May 13, 2024

Uffizzi Preview deployment-51846 was deleted.

@maestromac maestromac changed the title Fix Unable to Preview a Reply for a Comment Before Publishing it - New version Fix Unable to Preview a Reply for a Comment Before Publishing it May 16, 2024
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made an adjustment but LGTM

@maestromac maestromac merged commit f4a04bd into forem:main May 16, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Preview a Reply for a Comment Before Publishing it
2 participants