Display correct comments count in 'view full discussion' link #20960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20960 ⚙️ Updating now by workflow run 9130521473. What is Uffizzi? Learn more! |
benhalpern
approved these changes
May 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA Mac Siri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Show correct comments count in the "view full discussion" link. (based on comments display rules, for signed in users)
You can find more details about comments count and limitations in this pr description #20753
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Visit an article page which has a lot of comments + has spam comments (with score below hiding threshold (-400)
The
display_articles_countshould be updated for this article (it's updated when one of its comments scores is updated (added))"view full discussion" should include the correct comments count.
Added/updated tests?