Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delayed job that sends email notification on comment creation #5446

Conversation

VegaFromLyra
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Follow up to #5427

Related Tickets & Documents

#5305

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@VegaFromLyra VegaFromLyra requested a review from a team January 10, 2020 22:24
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 10, 2020
@VegaFromLyra
Copy link
Contributor Author

Flaky spec strikes again - https://travis-ci.com/thepracticaldev/dev.to/builds/143966113 tracked by #5228 (will try to take a dig at this flaky spec separately)

Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VegaFromLyra!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 11, 2020
@mstruve mstruve merged commit 61acfcd into forem:master Jan 13, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants