Android native audio feature support #7554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
the
PR: draft
fdocr
changed the title
pr-triage
bot
added
PR: unreviewed
maestromac
approved these changes
Apr 30, 2020
Comment on lines
+116
to
+117
| typeof AndroidBridge !== 'undefined' && | ||
| AndroidBridge !== null |
There was a problem hiding this comment.
Not a blocker but you can do these two operation in one. reference
Suggested change
| typeof AndroidBridge !== 'undefined' && | |
| AndroidBridge !== null | |
| typeof AndroidBridge != null |
pr-triage
bot
added
PR: partially-approved
benhalpern
approved these changes
May 1, 2020
pr-triage
bot
added
PR: merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This is the JS management of the Android Bridge calls required to make the Podcast Player work natively.
🚨🚨 NOTE FOR MERGE: Let's make this one a coordinated deploy with the next Native Android Beta Release to minimize impact on Podcast players not working anymore 🚨🚨
Related Tickets & Documents
Android repo PR
Added tests?
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?