Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Article Actions] Using position sticky #945

Merged
merged 1 commit into from Oct 18, 2018
Merged

[Article Actions] Using position sticky #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/stylesheets/article-show.scss
View file
Open in desktop
Expand Up @@ -647,7 +647,7 @@ header{
.article-actions{
text-align:center;
padding:9px 0px 16px;
position: fixed;
position: sticky;
bottom:0;
z-index:22;
background: white;
Expand Down
3 changes: 1 addition & 2 deletions app/assets/stylesheets/articles.scss
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@

.home{
position:relative;
overflow:hidden;
min-height:440px;
margin:auto;
max-width:1250px;
Expand Down Expand Up @@ -560,7 +559,7 @@
}
.bm-success{
display:none;
}
}
&.selected{
color: darken($purple, 33%);
background: transparent;
Expand Down
3 changes: 1 addition & 2 deletions app/assets/stylesheets/scaffolds.scss
View file
Open in desktop
Expand Up @@ -28,7 +28,6 @@ body {


.universal-page-content-wrapper{
overflow:hidden;
min-height:88vh;
visibility: visible;
&.stories-index,&.notifications-index,&.stories-search,&.podcast_episodes-index,&.reading_list_items-index,.tags-index{
Expand Down Expand Up @@ -94,4 +93,4 @@ button{

input[type="submit"]{
cursor:pointer;
};
};
2 changes: 1 addition & 1 deletion app/views/articles/show.html.erb
View file
Open in desktop
Expand Up @@ -165,7 +165,6 @@
<%= @article.processed_html.html_safe %>
</div>
<%= render "articles/collection", position: "bottom" %>
<%= render 'articles/actions' %>
</section>
<% if @article.body_markdown && @article.body_markdown.size > 900 %>
<% cache("article-about-author-#{@user.id}-#{@user.updated_at}", :expires_in => 100.hours) do %>
Expand Down Expand Up @@ -200,6 +199,7 @@
</div>
</div>
<% end %>
<%= render 'articles/actions' %>
</div>
<% cache("article-bottom-content-#{@article.cached_tag_list_array.sort}", :expires_in => 6.hours) do %>
<% @classic_article = Suggester::Articles::Classic.new(@article).get %>
Expand Down
1 change: 0 additions & 1 deletion app/views/layouts/application.html.erb
View file
Open in desktop
Expand Up @@ -21,7 +21,6 @@
<style>
.home {
position: relative;
overflow: hidden;
text-align: center;
min-height: 440px;
margin: auto;
Expand Down