Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[book] adds verification in ci section #743

Merged
merged 2 commits into from
Jul 16, 2023

Conversation

wookietreiber
Copy link
Contributor

see #742

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 88.37% and project coverage change: -0.29 ⚠️

Comparison is base (de17805) 76.25% compared to head (59cf8d9) 75.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   76.25%   75.97%   -0.29%     
==========================================
  Files          81       81              
  Lines        6148     6076      -72     
==========================================
- Hits         4688     4616      -72     
  Misses       1460     1460              
Impacted Files Coverage Δ
src/lib.rs 0.00% <0.00%> (ø)
src/manifest/reader.rs 0.00% <0.00%> (ø)
src/reporter/event/types/list_result/metadata.rs 0.00% <0.00%> (ø)
src/sub_command/show.rs 0.00% <0.00%> (ø)
src/manifest.rs 96.11% <100.00%> (-1.14%) ⬇️
src/reporter.rs 99.13% <100.00%> (-0.87%) ⬇️
src/sub_command/set.rs 98.98% <100.00%> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wookietreiber
Copy link
Contributor Author

I've added another commit to fix the new clippy lint.

@wookietreiber
Copy link
Contributor Author

wookietreiber commented Jul 16, 2023

I've added another commit to fix the new clippy lint.

You could also modify the GitHub actions to only trigger when certain files change, e.g. only run the rust stuff when any of the Cargo.* files or *.rs files change, and only run the mdbook stuff when anything in book/* changes, e.g. for the rust stuff:

on:
  pull_request:
    paths:
      - 'Cargo.toml'
      - 'Cargo.lock'
      - '**.rs'
  push:
    branches:
      - master
    paths:
      - 'Cargo.toml'
      - 'Cargo.lock'
      - '**.rs'

@foresterre
Copy link
Owner

Thanks!

@foresterre foresterre merged commit 0569209 into foresterre:main Jul 16, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants