setopt resize sampling_filter #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grammar: setflag [for-command] [flag-to-be-set]; setopt [for-comand] [option-to-be-set] [option-value];
5 tasks
Separation of the cli (Clap) related code to stew_cli reduced code duplication related to the cli code across sic and stew. However, any change or addition to this module becomes very tedious, especially since this module is currently constantly undergoing change in order to simplify and optimise usage of sic (and stew). For this reason, the module will be reintegrated within sic for the foreseeable future, at least until the cli interface stabilises. Then a decision will be made on what can be logically split to the cli module, and what should be kept separated (even if this means duplication).
foresterre
changed the title
foresterre
added a commit
that referenced
this pull request
Apr 21, 2019
Grammar for setopt (and setflag): setflag [for-command] [flag-to-be-set]; setopt [for-comand] [option-to-be-set] [option-value]; * Adapt parsing module to support the new image transformation engine. * Update parser grammar to allow for flags and options to be set. * Update parser to support setopt resize sampling_filter. * Reintegrate cli (Clap) related code within sic. Separation of the cli (Clap) related code to stew_cli reduced code duplication related to the cli code across sic and stew. However, any change or addition to this module becomes very tedious, especially since this module is currently constantly undergoing change in order to simplify and optimise usage of sic (and stew). For this reason, the module will be reintegrated within sic for the foreseeable future, at least until the cli interface stabilizes. Then a decision will be made on what can be logically split to the cli module, and what should be kept separated (even if this means duplication).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for options with
setopt resize sampling_filter <VAL>.issue: #44
related: https://github.com/foresterre/combostew/tree/optenv