Python, R: export_json bugfix, passing scale parameter to C++ #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardwliu
reviewed
Aug 18, 2023
R/R/forestry.R
Outdated
| @@ -787,7 +787,7 @@ forestry <- function(x, | |||
|
|
|||
| # Create vectors with the column means and SD's for scaling | |||
| colMeans <- rep(0, ncol(x)+1) | |||
| colSd <- rep(0, ncol(x)+1) | |||
| colSd <- rep(1, ncol(x)+1) | |||
There was a problem hiding this comment.
Could we leave this change out of this PR?
There was a problem hiding this comment.
@edwardwliu Yes, but this is a fix related to R - colSd is 1 by default - same fix for Python is col_sd = np.repeat(1.0, ncol + 1), other code in this PR is about code style update + added test.
Do you want me to fix only Python part for now?
There was a problem hiding this comment.
Fixed by reverting colSd back to 0 init and passing scale bool parameter to C++ function
Ilia-Shutov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python, R: col_sd = 1.0 by default (no scaling) as it is used in multiplying
export_json bugfix, RandomForest scale=False case