Python: RandomForest conforms to sklearn Estimator interface #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ilia-Shutov
force-pushed
the
is/sklearn
branch
from
6fc8165
to
a2e6b2b
Compare
Ilia-Shutov
force-pushed
the
is/sklearn
branch
from
a2e6b2b
to
368fe2e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: reconstruct_forest (reconstructForest) deserialization logic is changed as well as Python part of serialization: tree_counts contains 3 values for each tree instead of 4: numNodes, numSplitIdx, numAvIdx
Verified by adding test_pickle_unpickle.py, also sklearn test set contains its own pickle - unpickle test
Issue #98
Continuation of #101 (closed in favour of this one)