Skip to content

Commit

Permalink
B7161682765: Remove unused eventCategory.off() method
Browse files Browse the repository at this point in the history
  • Loading branch information
josquindebaz committed Mar 15, 2024
1 parent a504fe5 commit 7675211
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 28 deletions.
15 changes: 0 additions & 15 deletions src/eventCategory.js
Expand Up @@ -43,21 +43,6 @@ export default function eventCategory() {
return ensureEventHolderFor(name).register(callback);
};

/**
* Removed "binding" attached to event.
* @deprecated use unregister() instead
* @param name {String} Name of event
* @param binding {eventBinding} Binding
*/
that.off = function (name, binding) {
// eslint-disable-next-line no-console
console.warn(
"Sending off() to a category is deprecated. Send unregister() instead.",
);

return that.unregister(name, binding);
};

/**
* Removed "binding" attached to event.
* @param name {String} Name of event
Expand Down
13 changes: 0 additions & 13 deletions test/events.test.js
Expand Up @@ -278,19 +278,6 @@ describe("deprecated", () => {
console.warn = originalConsoleWarn;
});

it("off() category method delegates to unregister", () => {
// Arrange: an event
let someEvents = eventCategory();
let spy = jasmine.createSpy("unregister");

someEvents.unregister = spy;

someEvents.off("namedEvent", "something else");

expect(spy).toHaveBeenCalledWith("namedEvent", "something else");
expect(console.warn).toHaveBeenCalled();
});

it("onceOn() category method delegates to registerOnce", () => {
// Arrange: an event
let someEvents = eventCategory();
Expand Down

0 comments on commit 7675211

Please sign in to comment.