Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moving unconstrained bit to moving grab-mode #202

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

jmmaranan
Copy link
Collaborator

Fixes #201 - added new grab op bit to recognize moving grab mode.

@jmmaranan jmmaranan changed the title Add moving unconstrained bit moving mode Add moving unconstrained bit to moving grab-mode Apr 22, 2023
@mooey5775
Copy link

One very minor comment - I think moving windows now with Alt + F7 and arrow keys emits KEYBOARD_MOVING | unconstrained bit, which isn't currently matched by the modified if statement. A slight complication is that this combination of bits isn't directly exposed by the GrabOp enum - it might require some bit magic to work if you'd like to support it.

See https://gitlab.gnome.org/GNOME/mutter/-/commit/12773cf8e2954082f346dee300af624b25baf23c for relevant code

@jmmaranan
Copy link
Collaborator Author

jmmaranan commented Apr 25, 2023

Thank you @mooey5775, Forge does not use Alt + F7 or default move-window builtin to GNOME because I couldn't find the solution for it. So I implemented window swapping/moving with shortcuts instead in Forge. But I certainly can try to add the unconstrained bit to complete the builtin support for GNOME. Thank you for the tip!

@jmmaranan
Copy link
Collaborator Author

Tested in Fedora 38 Silverblue. And works as expected

@jmmaranan jmmaranan merged commit 6e1b061 into main Apr 25, 2023
@jmmaranan jmmaranan deleted the drag-n-drop-fix branch April 25, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: drag-n-drop via Super key does not work
2 participants