Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug when opening about window #233

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: bug when opening about window #233

merged 1 commit into from
May 31, 2023

Conversation

bennypowers
Copy link
Contributor

fixes #232

@jmmaranan jmmaranan self-requested a review May 31, 2023 17:08
jmmaranan
jmmaranan approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@jmmaranan jmmaranan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and good catch. Sorry, I was not able to check this as well as soon as you rebased.

@jmmaranan jmmaranan merged commit 8cc678b into forge-ext:main May 31, 2023
@bennypowers bennypowers deleted the fix/about-version-bug branch May 31, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmmaranan jmmaranan jmmaranan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: JS error when opening about window
2 participants
@bennypowers @jmmaranan