Fix: extensions review feedback

[jmmaranan]

forge-ext's extension, "Forge", version 74 has a new review:

JustPerfection posted a review on September 18, 2023:

1. Please remove the version from imports,
   because parent is the owner of prefs window and already specified the version:

   • line 20-21 prefs.js
   • line 4 lib/prefs/keyboard.js
   • line 4 lib/prefs/appearance.js
   • line 5-6 lib/prefs/widgets.js
   • line 3 lib/prefs/settings.js

2. Typo :p in

   • line 30 prefs.js (class name)
   • line 199 lib/extension/utils.js orientaton

3. You need to create objects on enable and null them out in disable (line 34 and 36 extension.js).
   Garbage collector cannot do it's job otherwise.

4. Selective disable is not allowed (line 69 extension.js):
   https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes

Please use the review page to follow up:

https://extensions.gnome.org/review/45065

[bennypowers]

Nice

The versioned imports were to appease the @girs/* typings. They should be made aware of it if they don't already know

[jrahmatzadeh]

@bennypowers If you mean for Gtk and Gdk, they are already specified here.

[bennypowers]

What I mean is that in order to pick up the types from the gtk and GDK packages then the query parameters must be included I believe this could be fixed with a single typing package for extensions which also includes the resources