Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Unicode CLDR identifier for Brazilian Portuguese #296

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

carlwgeorge
Copy link
Contributor

While packaging this extension for Fedora, rpmlint warned me that pt-br was an invalid locale directory. After some investigation, I confirmed that the Unicode CLDR standard for this is pt_BR, not pt-br. Other GNOME software and extensions also use the pt_BR identifier.

https://github.com/unicode-org/cldr/blob/release-43-1/common/main/pt_BR.xml
https://l10n.gnome.org/teams/pt_BR/
https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/45.0/po/pt_BR.po#L33
https://gitlab.gnome.org/GNOME/gnome-boxes/-/blob/45.0/po/pt_BR.po#L25
https://github.com/ubuntu/gnome-shell-extension-appindicator/blob/v57/locale/pt_BR.po#L15

While packaging this extension for Fedora, rpmlint warned me that pt-br
was an invalid locale directory.  After some investigation, I confirmed
that the Unicode CLDR standard for this is pt_BR, not pt-br.  Other
GNOME software and extensions also use the pt_BR identifier.

https://github.com/unicode-org/cldr/blob/release-43-1/common/main/pt_BR.xml
https://l10n.gnome.org/teams/pt_BR/
https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/45.0/po/pt_BR.po#L33
https://gitlab.gnome.org/GNOME/gnome-boxes/-/blob/45.0/po/pt_BR.po#L25
https://github.com/ubuntu/gnome-shell-extension-appindicator/blob/v57/locale/pt_BR.po#L15
@jmmaranan jmmaranan merged commit a519b49 into forge-ext:main Oct 10, 2023
@jmmaranan
Copy link
Collaborator

@carlwgeorge - the main branch is just for GNOME 45. Let me know if it needs to be in 44 too

@carlwgeorge
Copy link
Contributor Author

For my Fedora packaging purposes, I'm happy with GNOME 45 and up (Fedora 39 and up), so main should be fine for now. If a user later requests it for GNOME 44 / Fedora 38, I can send the equivalent PR to the gnome-44 branch. Thanks!

@carlwgeorge carlwgeorge deleted the pt_BR branch October 10, 2023 19:59
@jmmaranan
Copy link
Collaborator

Sounds good. I am assuming you are not waiting on anything from me for your packaging. And is there a link I can add to the readme?

@carlwgeorge
Copy link
Contributor Author

You are correct, the package review was completed a few days ago and I already pushed the first packages. For the readme I suggest using this link, which has a nice overview with links to the builds, updates, bug reports (for the package specifically, which I'll forward up here when appropriate), package sources, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants