Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add CI/CD workflows using github actions #373

Merged
merged 9 commits into from
Apr 2, 2024

Conversation

juarezr
Copy link
Contributor

@juarezr juarezr commented Apr 1, 2024

This PR would add:

  1. A Github workflow for testing each PR or push to the main branch
  2. Currently it only does source code formatting
  3. A Github workflow for releasing for GOE
    1. But it could work

@juarezr juarezr requested a review from jmmaranan April 1, 2024 19:31
Copy link
Collaborator

@jmmaranan jmmaranan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine with me. Not familiar with Github CI though

@jmmaranan jmmaranan merged commit 89f264d into forge-ext:main Apr 2, 2024
6 checks passed
@juarezr
Copy link
Contributor Author

juarezr commented Apr 4, 2024

@jmmaranan,

I forgot to tell you that the release workflow wasn't tested at all.

Anyway, it required that one would issue a release in the GitHub interface to trigger it.

@jmmaranan
Copy link
Collaborator

I just manually triggered it. Seems to produce the artifact. I am thinking to release the last PR that was merged last time and see if that triggers it.

@juarezr
Copy link
Contributor Author

juarezr commented Apr 6, 2024

@jmmaranan

It seems that the last step of the release workflow needs a little tweak.

<p>
  You are seeing this message because this HTTPS site requires a “Referer header” to be sent by your web browser, 
  but none was sent.This header is required for security reasons, to ensure that your browser is not being hijacked 
  by third parties.
</p>
<p>
  If you have configured your browser to disable “Referer” headers, please re-enable them, at least for this site, 
  or for HTTPS connections, or for “same-origin” requests.
</p>
<p>
  If you are using the &lt;meta name=&quot;referrer&quot; content=&quot;no-referrer&quot;&gt; tag or including 
  the “Referrer-Policy: no-referrer” header, please remove them. The CSRF protection requires the “Referer” header 
  to do strict referer checking. If you’re concerned about privacy, use alternatives like &lt;a rel=&quot;noreferrer&quot; …&gt; 
  for links to third-party sites.
</p>

Adding a switch -H' with a “Referer header” to the curl` command should do the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants