FORGEPLUGINS-217: Fixes compilation errors in Forge 3.7.2.Final+ #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- This is caused by FORGE-2759, but as specified in https://github.com/forge/core/#what-scope-should-my-addon-dependencies-be, exposed addons should not be in provided scope. Modifications ------------- Since UI classes are exposed to the outside world, it should not be declared as provided. Result ------ Compilation succeeds and works on all Forge versions.
|
@dipak-pawar @bartoszmajsak @lordofthejars can you guys review and merge this asap? Thanks |
|
Thanks @gastaldi ! |
|
Thank you Guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is caused by FORGE-2759, but as specified in https://github.com/forge/core/#what-scope-should-my-addon-dependencies-be, exposed addons should not be in provided scope.
Modifications
Since UI classes are exposed to the outside world, it should not be declared as provided.
Result
Compilation succeeds and works on all Forge versions.