FORGE-1802: Fixed possible CCE

forge · May 12, 2014 · 48d4d44 · 48d4d44
1 parent 4e4743c
commit 48d4d44
Showing 1 changed file with 22 additions and 19 deletions.
diff --git a/...java/impl/src/main/java/org/jboss/forge/addon/parser/java/resources/JavaResourceImpl.java b/...java/impl/src/main/java/org/jboss/forge/addon/parser/java/resources/JavaResourceImpl.java
@@ -117,32 +117,35 @@ protected synchronized List<Resource<?>> doListResources()
       try
       {
          List<Resource<?>> list = new LinkedList<>();
-         MemberHolder<?> memberHolder = getJavaType();
-         for (Member<?> member : memberHolder.getMembers())
+         JavaType<?> javaType = getJavaType();
+         if (javaType instanceof MemberHolder)
          {
-            if (member instanceof Field)
+            MemberHolder<?> memberHolder = (MemberHolder<?>) javaType;
+            for (Member<?> member : memberHolder.getMembers())
             {
-               list.add(new JavaFieldResourceImpl(getResourceFactory(), this, (Field<?>) member));
+               if (member instanceof Field)
+               {
+                  list.add(new JavaFieldResourceImpl(getResourceFactory(), this, (Field<?>) member));
+               }
+               else if (member instanceof Method)
+               {
+                  list.add(new JavaMethodResourceImpl(getResourceFactory(), this, (Method<?, ?>) member));
+               }
+               else
+               {
+                  throw new UnsupportedOperationException("Unknown member type: " + member);
+               }
             }
-            else if (member instanceof Method)
-            {
-               list.add(new JavaMethodResourceImpl(getResourceFactory(), this, (Method<?, ?>) member));
-            }
-            else
-            {
-               throw new UnsupportedOperationException("Unknown member type: " + member);
-            }
-         }
 
-         if (memberHolder instanceof JavaEnum)
-         {
-            List<EnumConstant<?>> enumConstants = ((JavaEnum) memberHolder).getEnumConstants();
-            for (EnumConstant<?> e : enumConstants)
+            if (memberHolder instanceof JavaEnum)
             {
-               list.add(new EnumConstantResourceImpl(getResourceFactory(), this, e));
+               List<EnumConstant<?>> enumConstants = ((JavaEnum) memberHolder).getEnumConstants();
+               for (EnumConstant<?> e : enumConstants)
+               {
+                  list.add(new EnumConstantResourceImpl(getResourceFactory(), this, e));
+               }
             }
          }
-
          return list;
       }
       catch (ParserException e)