Skip to content

Commit

Permalink
FORGE-2263: Strengthen test harness on CDI Commands
Browse files Browse the repository at this point in the history
  • Loading branch information
agoncal committed Mar 2, 2015
1 parent 8ccc2e5 commit 9f7f35e
Show file tree
Hide file tree
Showing 7 changed files with 629 additions and 260 deletions.
Expand Up @@ -7,9 +7,10 @@

package org.jboss.forge.addon.javaee.cdi.ui;

import static org.hamcrest.CoreMatchers.instanceOf;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.not;
import static org.hamcrest.CoreMatchers.*;
import static org.junit.Assert.*;

import java.util.concurrent.TimeUnit;

import javax.enterprise.context.NormalScope;
import javax.enterprise.context.SessionScoped;
Expand All @@ -20,10 +21,13 @@
import org.jboss.arquillian.container.test.api.Deployment;
import org.jboss.arquillian.junit.Arquillian;
import org.jboss.forge.addon.javaee.ProjectHelper;
import org.jboss.forge.addon.javaee.cdi.CDIFacet;
import org.jboss.forge.addon.parser.java.facets.JavaSourceFacet;
import org.jboss.forge.addon.parser.java.resources.JavaResource;
import org.jboss.forge.addon.projects.Project;
import org.jboss.forge.addon.shell.test.ShellTest;
import org.jboss.forge.addon.ui.controller.CommandController;
import org.jboss.forge.addon.ui.metadata.UICommandMetadata;
import org.jboss.forge.addon.ui.result.Failed;
import org.jboss.forge.addon.ui.result.Result;
import org.jboss.forge.addon.ui.test.UITestHarness;
Expand All @@ -36,6 +40,7 @@
import org.jboss.forge.roaster.model.source.JavaAnnotationSource;
import org.jboss.shrinkwrap.api.ShrinkWrap;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;

Expand All @@ -50,6 +55,7 @@ public class NewBeanCommandTest
@AddonDeployments({
@AddonDeployment(name = "org.jboss.forge.addon:ui"),
@AddonDeployment(name = "org.jboss.forge.addon:ui-test-harness"),
@AddonDeployment(name = "org.jboss.forge.addon:shell-test-harness"),
@AddonDeployment(name = "org.jboss.forge.addon:javaee"),
@AddonDeployment(name = "org.jboss.forge.addon:maven")
})
Expand All @@ -65,84 +71,134 @@ public static AddonArchive getDeployment()
AddonDependencyEntry.create("org.jboss.forge.addon:javaee"),
AddonDependencyEntry.create("org.jboss.forge.addon:maven"),
AddonDependencyEntry.create("org.jboss.forge.addon:ui"),
AddonDependencyEntry.create("org.jboss.forge.addon:ui-test-harness")
AddonDependencyEntry.create("org.jboss.forge.addon:ui-test-harness"),
AddonDependencyEntry.create("org.jboss.forge.addon:shell-test-harness")
);
}

@Inject
private UITestHarness testHarness;
private UITestHarness uiTestHarness;

@Inject
private ShellTest shellTest;

@Inject
private ProjectHelper projectHelper;

private Project project;

@Before
public void setUp()
{
project = projectHelper.createJavaLibraryProject();
projectHelper.installCDI_1_0(project);
}

@Test
public void checkCommandMetadata() throws Exception
{
try (CommandController controller = uiTestHarness.createCommandController(NewBeanCommand.class,
project.getRoot()))
{
controller.initialize();
// Checks the command metadata
assertTrue(controller.getCommand() instanceof NewBeanCommand);
UICommandMetadata metadata = controller.getMetadata();
assertEquals("CDI: New Bean", metadata.getName());
assertEquals("Java", metadata.getCategory().getName());
assertEquals("CDI", metadata.getCategory().getSubCategory().getName());
assertEquals(8, controller.getInputs().size());
assertFalse("Project is created, shouldn't have targetLocation", controller.hasInput("targetLocation"));
assertTrue(controller.hasInput("named"));
assertTrue(controller.hasInput("targetPackage"));
assertTrue(controller.hasInput("overwrite"));
assertTrue(controller.hasInput("scoped"));
assertTrue(controller.hasInput("customScopeAnnotation"));
assertTrue(controller.hasInput("qualifier"));
assertTrue(controller.hasInput("alternative"));
assertTrue(controller.hasInput("withNamed"));
assertTrue(controller.getValueFor("targetPackage").toString().endsWith("unknown"));
}
}

@Test
public void checkCommandShell() throws Exception
{
shellTest.getShell().setCurrentResource(project.getRoot());
Result result = shellTest.execute("cdi-new-bean --named Dummy", 10, TimeUnit.SECONDS);

Assert.assertThat(result, not(instanceOf(Failed.class)));
Assert.assertTrue(project.hasFacet(CDIFacet.class));
}

@Test
public void testCreateNewBean() throws Exception
{
Project project = projectHelper.createJavaLibraryProject();
projectHelper.installCDI_1_0(project);
CommandController controller = testHarness.createCommandController(NewBeanCommand.class,
project.getRoot());
controller.initialize();
controller.setValueFor("named", "MyServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("scoped", BeanScope.SESSION.name());
Assert.assertTrue(controller.isValid());
Assert.assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
try (CommandController controller = uiTestHarness.createCommandController(NewBeanCommand.class,
project.getRoot()))
{
controller.initialize();
controller.setValueFor("named", "MyServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("scoped", BeanScope.SESSION.name());
assertTrue(controller.isValid());
assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
}

JavaSourceFacet facet = project.getFacet(JavaSourceFacet.class);
JavaResource javaResource = facet.getJavaResource("org.jboss.forge.test.MyServiceBean");
Assert.assertNotNull(javaResource);
Assert.assertThat(javaResource.getJavaType(), is(instanceOf(JavaClass.class)));
Assert.assertTrue(javaResource.getJavaType().hasAnnotation(SessionScoped.class));
assertTrue(javaResource.getJavaType().hasAnnotation(SessionScoped.class));
Assert.assertFalse(javaResource.getJavaType().hasAnnotation(Named.class));
Assert.assertFalse(javaResource.getJavaType().hasAnnotation(Alternative.class));
}

@Test
public void testCreateNewBeanWithAlternativeAndNamed() throws Exception
{
Project project = projectHelper.createJavaLibraryProject();
projectHelper.installCDI_1_0(project);
CommandController controller = testHarness.createCommandController(NewBeanCommand.class,
project.getRoot());
controller.initialize();
controller.setValueFor("named", "MyServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("scoped", BeanScope.SESSION.name());
controller.setValueFor("alternative", true);
controller.setValueFor("withNamed", true);
Assert.assertTrue(controller.isValid());
Assert.assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
try (CommandController controller = uiTestHarness.createCommandController(NewBeanCommand.class,
project.getRoot()))
{
controller.initialize();
controller.setValueFor("named", "MyServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("scoped", BeanScope.SESSION.name());
controller.setValueFor("alternative", true);
controller.setValueFor("withNamed", true);
assertTrue(controller.isValid());
assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
}

JavaSourceFacet facet = project.getFacet(JavaSourceFacet.class);
JavaResource javaResource = facet.getJavaResource("org.jboss.forge.test.MyServiceBean");
Assert.assertNotNull(javaResource);
Assert.assertThat(javaResource.getJavaType(), is(instanceOf(JavaClass.class)));
Assert.assertTrue(javaResource.getJavaType().hasAnnotation(SessionScoped.class));
Assert.assertTrue(javaResource.getJavaType().hasAnnotation(Named.class));
Assert.assertTrue(javaResource.getJavaType().hasAnnotation(Alternative.class));
assertTrue(javaResource.getJavaType().hasAnnotation(SessionScoped.class));
assertTrue(javaResource.getJavaType().hasAnnotation(Named.class));
assertTrue(javaResource.getJavaType().hasAnnotation(Alternative.class));
}

@Test
public void testCreateNewBeanWithNoAlternativeAndNamed() throws Exception
{
Project project = projectHelper.createJavaLibraryProject();
projectHelper.installCDI_1_0(project);
CommandController controller = testHarness.createCommandController(NewBeanCommand.class,
project.getRoot());
controller.initialize();
controller.setValueFor("named", "MyServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("alternative", false);
controller.setValueFor("withNamed", false);
Assert.assertTrue(controller.isValid());
Assert.assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
try (CommandController controller = uiTestHarness.createCommandController(NewBeanCommand.class,
project.getRoot()))
{
controller.initialize();
controller.setValueFor("named", "MyServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("alternative", false);
controller.setValueFor("withNamed", false);
assertTrue(controller.isValid());
assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
}

JavaSourceFacet facet = project.getFacet(JavaSourceFacet.class);
JavaResource javaResource = facet.getJavaResource("org.jboss.forge.test.MyServiceBean");
Expand All @@ -155,49 +211,49 @@ public void testCreateNewBeanWithNoAlternativeAndNamed() throws Exception
@Test
public void testCreateNewBeanWithQualifier() throws Exception
{
Project project = projectHelper.createJavaLibraryProject();
projectHelper.installCDI_1_0(project);
CommandController controller = testHarness.createCommandController(NewBeanCommand.class,
project.getRoot());
controller.initialize();
controller.setValueFor("named", "MyServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("qualifier", "javax.inject.Named");
Assert.assertTrue(controller.isValid());
Assert.assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
try (CommandController controller = uiTestHarness.createCommandController(NewBeanCommand.class,
project.getRoot()))
{
controller.initialize();
controller.setValueFor("named", "MyServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("qualifier", "javax.inject.Named");
assertTrue(controller.isValid());
assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
}

JavaSourceFacet facet = project.getFacet(JavaSourceFacet.class);
JavaResource javaResource = facet.getJavaResource("org.jboss.forge.test.MyServiceBean");
Assert.assertNotNull(javaResource);
Assert.assertThat(javaResource.getJavaType(), is(instanceOf(JavaClass.class)));
Assert.assertFalse(javaResource.getJavaType().hasAnnotation(SessionScoped.class));
Assert.assertTrue(javaResource.getJavaType().hasAnnotation(Named.class));
assertTrue(javaResource.getJavaType().hasAnnotation(Named.class));
Assert.assertFalse(javaResource.getJavaType().hasAnnotation(Alternative.class));
}

@Test
public void testCreateNewBeanCustomScope() throws Exception
{
Project project = projectHelper.createJavaLibraryProject();
projectHelper.installCDI_1_0(project);
JavaAnnotationSource ann = Roaster.create(JavaAnnotationSource.class).setName("MyCustomScope")
.setPackage("org.jboss.forge.test.scope");
ann.addAnnotation(NormalScope.class);
project.getFacet(JavaSourceFacet.class).saveJavaSource(ann);
CommandController controller = testHarness.createCommandController(NewBeanCommand.class,
project.getRoot());
controller.initialize();
controller.setValueFor("named", "MyCustomServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("scoped", BeanScope.CUSTOM.name());
Assert.assertFalse(controller.isValid());
controller.setValueFor("customScopeAnnotation", ann.getQualifiedName());
Assert.assertTrue(controller.isValid());
Assert.assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
try (CommandController controller = uiTestHarness.createCommandController(NewBeanCommand.class,
project.getRoot()))
{
controller.initialize();
controller.setValueFor("named", "MyCustomServiceBean");
controller.setValueFor("targetPackage", "org.jboss.forge.test");
controller.setValueFor("scoped", BeanScope.CUSTOM.name());
Assert.assertFalse(controller.isValid());
controller.setValueFor("customScopeAnnotation", ann.getQualifiedName());
assertTrue(controller.isValid());
assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertThat(result, is(not(instanceOf(Failed.class))));
}

JavaSourceFacet facet = project.getFacet(JavaSourceFacet.class);
JavaResource javaResource = facet.getJavaResource("org.jboss.forge.test.MyCustomServiceBean");
Expand All @@ -206,4 +262,4 @@ public void testCreateNewBeanCustomScope() throws Exception
Assert.assertFalse(javaResource.getJavaType().hasAnnotation(Named.class));
Assert.assertFalse(javaResource.getJavaType().hasAnnotation(Alternative.class));
}
}
}

0 comments on commit 9f7f35e

Please sign in to comment.