Better Code legibility

forge · Aug 22, 2013 · c1691b2 · c1691b2
1 parent ac8bf25
commit c1691b2
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/shell/impl/src/main/java/org/jboss/forge/addon/shell/aesh/ShellWizard.java b/shell/impl/src/main/java/org/jboss/forge/addon/shell/aesh/ShellWizard.java
@@ -96,28 +96,30 @@ public List<String> getCompletionOptions(String typed, String line)
    {
       List<String> result = new ArrayList<String>();
       boolean unvalued = Strings.isNullOrEmpty(typed);
-      int idx = steps.size() - 1;
-      STEP: for (; idx > 0; idx--)
+      int size = steps.size();
+
+      int idx;
+
+      STEP_LOOP: for (idx = size - 1; idx > 0; idx--)
       {
          for (String option : steps.get(idx).inputs.keySet())
          {
             if (line.contains("--" + option))
             {
-               break STEP;
+               break STEP_LOOP;
             }
          }
       }
       Set<String> candidates = new HashSet<String>();
-      for (int i = idx; i < steps.size(); i++)
+      for (int i = idx; i < size; i++)
       {
          candidates.addAll(steps.get(i).inputs.keySet());
       }
       for (String option : candidates)
       {
          if (unvalued || option.startsWith(typed))
          {
-            String dashedOption = "--" + option;
-            result.add(dashedOption);
+            result.add("--" + option);
          }
       }
       removeExistingOptions(line, result);