Skip to content

Commit

Permalink
Removed redundant controller and fail check from the test
Browse files Browse the repository at this point in the history
  • Loading branch information
VineetReynolds committed Mar 12, 2014
1 parent 9a9c402 commit e96e83c
Showing 1 changed file with 10 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
import org.junit.Test;
import org.junit.runner.RunWith;

import static org.junit.Assert.fail;
import static org.hamcrest.core.IsEqual.equalTo;
import static org.junit.Assert.assertThat;

@RunWith(Arquillian.class)
public class NewFieldWizardTest
Expand Down Expand Up @@ -185,15 +186,9 @@ public void testNewOneToManyField() throws Exception
Assert.assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertFalse(result instanceof Failed);
if (result instanceof CompositeResult)
{
CompositeResult compositeResult = (CompositeResult) result;
Assert.assertEquals("Relationship One-to-Many created", compositeResult.getResults().get(1).getMessage());
}
else
{
fail("Result is of type " + CompositeResult.class.getSimpleName() + " is expected.");
}
assertThat("Result should be of type CompositeResult", result instanceof CompositeResult, equalTo(true));

This comment has been minimized.

Copy link
@gastaldi

gastaldi Mar 12, 2014

Member

There is a CoreMatchers.instanceOf() matcher that could be used instead

This comment has been minimized.

Copy link
@VineetReynolds

VineetReynolds Mar 12, 2014

Author Member

Noted, and done in the next commit.

CompositeResult compositeResult = (CompositeResult) result;
Assert.assertEquals("Relationship One-to-Many created", compositeResult.getResults().get(1).getMessage());
}
JavaClass javaClass = (JavaClass) entity.getJavaSource();
Assert.assertTrue(javaClass.hasField("accounts"));
Expand All @@ -219,20 +214,14 @@ public void testNewOneToManyEagerFetchField() throws Exception
controller.setValueFor("type", otherEntity.getJavaSource().getCanonicalName());
controller.setValueFor("relationshipType", RelationshipType.ONE_TO_MANY);
Assert.assertTrue(controller.canMoveToNextStep());
WizardCommandController next = controller.next();
next.setValueFor("fetchType", FetchType.EAGER);
controller.next();
controller.setValueFor("fetchType", FetchType.EAGER);
Assert.assertTrue(controller.canExecute());
Result result = controller.execute();
Assert.assertFalse(result instanceof Failed);
if (result instanceof CompositeResult)
{
CompositeResult compositeResult = (CompositeResult) result;
Assert.assertEquals("Relationship One-to-Many created", compositeResult.getResults().get(1).getMessage());
}
else
{
fail("Result is of type " + CompositeResult.class.getSimpleName() + " is expected.");
}
assertThat ("Result should be of type CompositeResult", result instanceof CompositeResult, equalTo(true));
CompositeResult compositeResult = (CompositeResult) result;
Assert.assertEquals("Relationship One-to-Many created", compositeResult.getResults().get(1).getMessage());
}
JavaClass javaClass = (JavaClass) entity.getJavaSource();
Assert.assertTrue(javaClass.hasField("accounts"));
Expand Down

0 comments on commit e96e83c

Please sign in to comment.