Implemented FORGE-863 #310
Conversation
| List<Repository> repositories = profile.getRepositories(); | ||
| for (Repository repository : repositories) | ||
| { | ||
| settingsRepos.add(RepositoryUtils.convertFromMavenSettingsRepository(repository)); |
There was a problem hiding this comment.
Is this handled by "populateDefaults()" ?
There was a problem hiding this comment.
to be more precise, it is handle by the method "processRepositoriesInSettings" in DefaultMavenExecutionRequestPopulator
There was a problem hiding this comment.
By the code present in DefaultMavenExecutionRequestPopulator.populateDefaults, I see that mirrors are also handled. Could you check if the code below is really needed yet ?
There was a problem hiding this comment.
Here we need to set the mirrorSelector on the repositorySession
and repositorySession is not handled by populateDefaults
otherwise maven.getMavenProject().getRemoteProjectRepositories(); won't have the correct repositories...
to avoid setting the mirror stuff on the repositorySession we would need to use org.apache.maven.DefaultMaven.newRepositorySession( MavenExecutionRequest request )
But I don't know how we can use this method inside forge...see my other comment on that subject
|
Merged. Thanks !!! |
No description provided.