Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Forge javadoc in one zip archive #322

Merged
merged 1 commit into from May 28, 2013
Merged

Conversation

ivannov
Copy link
Member

@ivannov ivannov commented May 28, 2013

No description provided.

@gastaldi
Copy link
Member

Looks good! Great job

@gastaldi
Copy link
Member

When I ran, I noticed that two files of 1.8MB each were created with the same content: one JAR in the javadoc module and a ZIP in the dist module. Is that supposed to happen ? Perhaps we could leave only the javadoc module instead of adding in the dist. I can change that, thoughts ?

@gastaldi gastaldi merged commit 8ac9f9d into forge:master May 28, 2013
@gastaldi
Copy link
Member

Merged

@lincolnthree
Copy link
Member

I don't think we need JavaDocs in the Dist, personally, but we can perhaps
ask some other people and see what they think. Most IDEs pull down the
JavaDocs anyway, and we can always host them online automatically. I think
that javadocs in the dist was ivannov's intent.

On Tue, May 28, 2013 at 7:09 PM, George Gastaldi
notifications@github.comwrote:

Merged


Reply to this email directly or view it on GitHubhttps://github.com//pull/322#issuecomment-18586272
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

@lincolnthree
Copy link
Member

So we can discuss and find what people want. Personally, I don't really
care either way, but I prefer to keep the dist ZIP file smaller rather than
larger.

On Tue, May 28, 2013 at 10:05 PM, Lincoln Baxter, III <
lincolnbaxter@gmail.com> wrote:

I don't think we need JavaDocs in the Dist, personally, but we can perhaps
ask some other people and see what they think. Most IDEs pull down the
JavaDocs anyway, and we can always host them online automatically. I think
that javadocs in the dist was ivannov's intent.

On Tue, May 28, 2013 at 7:09 PM, George Gastaldi <notifications@github.com

wrote:

Merged


Reply to this email directly or view it on GitHubhttps://github.com//pull/322#issuecomment-18586272
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants