FORGE-1960: Created empty project provider + type #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build 625 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 599 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 600 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 627 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
| * | ||
| * @author <a href="ggastald@redhat.com">George Gastaldi</a> | ||
| */ | ||
| public class EmptyMetadataFacet extends AbstractFacet<Project> implements MetadataFacet |
There was a problem hiding this comment.
I think "Empty" is the wrong word here. I think "Basic" or "General" or "Generic" or something would be more accurate. Empty implies that nothing is there, but there is something there. It's just something we don't really know or care how to describe.
|
Build 612 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 637 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 623 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 649 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 625 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 627 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 651 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 628 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
|
Build 652 outcome was FAILURE using a merge of 957f6b7 Build problems:Failed tests detected Failed tests |
gastaldi
force-pushed
the
master
branch
3 times, most recently
from
9edb4fc
to
70c9a15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created PR for discussion, do not merge yet