ROASTER-82: Added support for var-args parameters

forge · Sep 28, 2015 · 84697c0 · 84697c0
1 parent b14901b
commit 84697c0
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 4 deletions.
diff --git a/api/src/main/java/org/jboss/forge/roaster/model/Parameter.java b/api/src/main/java/org/jboss/forge/roaster/model/Parameter.java
@@ -14,7 +14,18 @@
  */
 public interface Parameter<O extends JavaType<O>> extends AnnotationTarget<O>, FinalCapable
 {
+   /**
+    * @return the name of this parameter
+    */
    String getName();
 
+   /**
+    * @return the type of this parameter
+    */
    Type<O> getType();
+
+   /**
+    * @return if this parameter is declared as varargs (...)
+    */
+   boolean isVarArgs();
 }
diff --git a/api/src/main/java/org/jboss/forge/roaster/model/source/ParameterSource.java b/api/src/main/java/org/jboss/forge/roaster/model/source/ParameterSource.java
@@ -18,4 +18,8 @@
 public interface ParameterSource<O extends JavaSource<O>> extends Parameter<O>,
          AnnotationTargetSource<O, ParameterSource<O>>, FinalCapableSource<ParameterSource<O>>
 {
+   /**
+    * @param variableArity if the parameter should be a var-args parameter
+    */
+   ParameterSource<O> setVarArgs(boolean variableArity);
 }
diff --git a/impl/src/main/java/org/jboss/forge/roaster/model/impl/MethodImpl.java b/impl/src/main/java/org/jboss/forge/roaster/model/impl/MethodImpl.java
@@ -561,10 +561,6 @@ public MethodSource<O> setVisibility(final Visibility scope)
       return Visibility.set(this, scope);
    }
 
-   /*
-    * Interfaces
-    */
-
    @Override
    public String toString()
    {

diff --git a/impl/src/main/java/org/jboss/forge/roaster/model/impl/ParameterImpl.java b/impl/src/main/java/org/jboss/forge/roaster/model/impl/ParameterImpl.java
@@ -134,6 +134,19 @@ public ParameterSource<O> setFinal(boolean finl)
       return this;
    }
 
+   @Override
+   public ParameterSource<O> setVarArgs(boolean variableArity)
+   {
+      param.setVarargs(variableArity);
+      return this;
+   }
+
+   @Override
+   public boolean isVarArgs()
+   {
+      return param.isVarargs();
+   }
+
    @Override
    public Object getInternal()
    {

diff --git a/impl/src/test/java/org/jboss/forge/test/roaster/model/ParameterTest.java b/impl/src/test/java/org/jboss/forge/test/roaster/model/ParameterTest.java
@@ -48,4 +48,17 @@ public void testParameterAsFinal() throws Exception
       Assert.assertThat(parameter.isFinal(), is(false));
    }
 
+   @Test
+   public void testParameterShouldBeVarargs() throws Exception
+   {
+      JavaClassSource clazz = Roaster.create(JavaClassSource.class).setName("TestClass");
+      ParameterSource<JavaClassSource> parameter = clazz.addMethod().setReturnTypeVoid().setName("myMethod")
+               .addParameter(String.class, "parameter").setVarArgs(true);
+      Assert.assertThat(parameter.isVarArgs(), is(true));
+      parameter.setVarArgs(false);
+      Assert.assertThat(parameter.isVarArgs(), is(false));
+      parameter.setVarArgs(true);
+      Assert.assertThat(parameter.isVarArgs(), is(true));
+   }
+
 }