-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not display on Atom 208 #10
Comments
Duplicate of #8 |
Not really ... |
@JohnMurga looks like you're right, these are distinct-but-related changes that happened in quick succession. |
Going to investigate using Markers instead of relying on manipulating layers in the editor directly. |
I got a response that may be useful ... |
Good call, @JohnMurga. Inserting into the shadowRoot gets it closer, but still having issues. First, the ruler gets thrown off horizontally by e.g. having line numbers enabled, and second, when the ruler is positioned correctly, it overlays the cursor so you don't see the blink effect. Opacity could be a solution to the latter but it's probably not worth thinking too hard about before we figure out if adding a custom element to the shadowRoot is even the right way to move forward. Considered using Markers instead of "manual" DOM manipulation - thoughts anyone? |
Another idea entirely is to replace all of the JS code with a pure-CSS solution. The following is a rough draft: atom-text-editor.is-focused::shadow {
.cursors {
.cursor::before {
content: " ";
display: block;
height: 100%;
width: 1px;
transform: translateX(-0px) scaleY(1000);
border-left: 1px solid @text-color-subtle;
overflow: hidden;
}
}
} Two problems with this approach though:
|
Instead of appending the Element to the old underlayer, it is now appended to the |
Other similar packages have the same issue with 208
The text was updated successfully, but these errors were encountered: