Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes warnings when installing with OSX/homebrew #3

Merged
merged 4 commits into from Apr 7, 2014

Conversation

seryl
Copy link
Contributor

@seryl seryl commented Apr 1, 2014

As shown below, fixes the following:

josh@kiva: Desktop/zklua> make
gcc -c `pkg-config --cflags lua5.1` -fPIC -O2  zklua.c
Package lua5.1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `lua5.1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'lua5.1' found
zklua.c:291:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
zklua.c:312:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
zklua.c:689:1: warning: control may reach end of non-void function [-Wreturn-type]
}
^
zklua.c:697:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
zklua.c:705:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
5 warnings generated.

@seryl
Copy link
Contributor Author

seryl commented Apr 2, 2014

Still seeing:

Cloning into 'zklua'...
remote: Counting objects: 21, done.
remote: Compressing objects: 100% (19/19), done.
remote: Total 21 (delta 1), reused 17 (delta 1)
Receiving objects: 100% (21/21), 25.32 KiB | 0 bytes/s, done.
Resolving deltas: 100% (1/1), done.
Checking connectivity... done.
export MACOSX_DEPLOYMENT_TARGET=10.5; gcc -O2 -fPIC -I/usr/local/opt/lua/include -c zklua.c -o zklua.o
export MACOSX_DEPLOYMENT_TARGET=10.5; gcc -bundle -undefined dynamic_lookup -all_load -o zklua.so -L/usr/local/opt/lua/lib zklua.o -lzklua
ld: library not found for -lzklua
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Error: Build error: Failed compiling module zklua.so

@seryl
Copy link
Contributor Author

seryl commented Apr 2, 2014

Actual make currently works, and the library installs properly

forhappy added a commit that referenced this pull request Apr 7, 2014
Fixes warnings when installing with OSX/homebrew
@forhappy forhappy merged commit bfca755 into forhappy:master Apr 7, 2014
@seryl seryl deleted the fix_osx_warnings branch April 9, 2014 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants