upgrade lodash to 4.17.2 #241
Conversation
|
@parikhshiv I'm assuming all the automated tests pass as well? Also, if you're in the office today, come find me - I can let you know an easier way to test all graphs in the gallery. |
|
btw, nice work! This has been a long time coming, and i'm personally looking forward to not having to dig up ancient lodash docs every time :) |
|
Hi @narenranjit - thanks! As discussed, the automated tests are not currently running (older version of Jasmine), and I wasn't able to get them running. I did use your methods to test all the graphs in the gallery (once I started a local server, I could test the example graphs built into the repo directly, which match all graphs in the showcase gallery). They all render perfectly with the lodash update, but let me know if you want to see how I'm testing. |
|
Turns out the Jasmine tests do still work - just needed to run them in the browser. Good thing too - I had only copied over the core build of lodash 4.17.2 in our vendors folder, and so we were working with limited functions. This broke most of our tests, but replacing that core build with the full build of lodash now has all of our tests passing, so I'm going to go ahead and merge this PR. In terms of the other issues: As we discussed, I'm going to hold off on merging #237 for now, as it sets an additional global variable that we may not need. I'll go ahead and update #242 - I think we may be okay with our tests - I looked into upgrades from Jasmine 1 to 2, and it looks like we've accounted for the changes in our tests. |
For #217 - upgrading to latest version of lodash (4.17.2). The following functions have changed since lodash 2.4.2 (changes are visible in https://lodash.com/docs/3.10.1):
_.all -> _.every
_.any -> _.some
_.contains -> _.includes
_.invoke -> _.invokeMap
_.pluck -> _.map
_.select -> _.filter
_.unique -> _.uniq
Also, the 'this' argument (3rd parameter) has been removed from most methods - from docs:
Removed thisArg params from most methods because they were largely unused, complicated implementations, & can be tackled with _.bind, Function#bind, or arrow functions.
In this PR, I've replaced all instances of the above functions which are out of date, and tried to address every instance of the thisArg being used (by replacing it with Function#bind) - possible that I missed some, but unlikely - I've tested a basic line graph locally to sanity check.