add distanceX and distanceY to tooltip

[senluchen2015]

• distanceX and distanceY, if given overrides the distance option.
• change clampPosition to the edge and not opposite. ie. if you go distanceY = 400 it will max out on the top of the graph.

Demo:
http://jsfiddle.net/ucstdgsa/

[senluchen2015]

@parikhshiv and @narenranjit

When you guys get the chance can you take a look at this and #251?

The only thing I am still debating about is distanceX, right now a positive number will send the tooltip left while a negative number will send the tooltip right. Not sure if that is intuitive, so might be best to switch it.

[mmrj]

@senluchen2015 i haven't looked at the code or demo, so take with a grain of salt -- but i vote for distanceX positive values moving right / negative values moving left like a standard number line.

[parikhshiv]

Code looks good to me, but I'd agree with Molly that positive values should move the tooltip right (and vice versa). Also, I'm not able to reposition the tooltip in the jsfiddle example, but I might be doing something wrong.

[senluchen2015]

Flipped the direction so that positive number means towards right on distanceX. Positive distanceY is still going up.

Demo:
http://jsfiddle.net/ucstdgsa/1/

[narenranjit]

wouldn't this break if distanceX is explicitly set to 0?

[senluchen2015]

I think this will fix

var distanceX = this.options.tooltip.distanceX !== undefined ? this.options.tooltip.distanceX : distance;
var distanceY = this.options.tooltip.distanceY !== undefined ? this.options.tooltip.distanceY : distance;

[narenranjit]

I'd change the check to !=null (which'll catch both null and undefined)

[parikhshiv]

you could also use !=undefined (could be more implicit?)

[parikhshiv]

*as long as we never overwrite undefined (same goes for null though)

[drosen0]

@parikhshiv,
At one time, you could overwrite undefined, but it hasn't been possible since ES5. Besides, the build process (uglify) replaces undefined with void 0.

[senluchen2015]

Updated tooltip distance to take object or number

tooltip: {
    distance: {
          x: 100,
          y: 20,
    }
}

http://jsfiddle.net/ucstdgsa/2/