Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename _.nw #261

Closed
wants to merge 2 commits into from
Closed

rename _.nw #261

wants to merge 2 commits into from

Conversation

breadbaker
Copy link
Contributor

@breadbaker breadbaker commented Nov 8, 2017

this pr was opened a year ago:

#237

relying on _ not to be touched is dangerous and its breaks in my use case.

can we rename nwUtils to avoid this conflict or suggest a better path forward.

we want to continue to use contour, and not have to work on a stale version nor constantly have to merge diverged branches.

@narenranjit
Copy link
Contributor

Thanks for this (and hi Dan!). We're exploring removing the lodash dependency from contour entirely in the next month or so. That'll make this redundant, so I'll keep this open for a while until we explore that further.

Out of curiosity, what browsers do you need to support for projects using this?

@breadbaker
Copy link
Contributor Author

Ok that sounds good.

Its not about browser, its about the globally name spaced lodash being redefined somewhere and eliminating the extensions made to it when Contour initialized.

@narenranjit
Copy link
Contributor

I asked about Browser support because removing the lodash dependency will probably mean reducing the supported browser list, so if you use IE8 for instance it probably won't help you much :)

@breadbaker
Copy link
Contributor Author

Honestly I'd forgotten IE8 existed.

# Conflicts:
#	src/scripts/core/axis/y-axis.js
@narenranjit
Copy link
Contributor

closing because removing lodash dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants