Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork, Commit, Merge - Easy Issue (JSON) #1596

Open
nikohoffren opened this issue Nov 18, 2023 · 12 comments · Fixed by #1605 or #1998
Open

Fork, Commit, Merge - Easy Issue (JSON) #1596

nikohoffren opened this issue Nov 18, 2023 · 12 comments · Fixed by #1605 or #1998

Comments

@nikohoffren
Copy link
Member

Fork, Commit, Merge - Easy Issue (JSON)

Creating a JSON data file

Note: You don't have ask permission to start solving the issue or get assigned, since these issues are supposed to be always open for new contributors. The actions-user bot will reset the file back to previous state for the next contributor after your commit is merged. So you can just simply start working with the issue right away!

Description:

The goal of this task is to create a JSON file that stores simple data. This will be a list of users where each user has a name, email, and ID.

json-easy

Acceptance Criteria:

  • The file should contain data for at least 5 users.
  • Each user should have the following fields:
    • id: a unique identifier for each user.
    • name: the user's name.
    • email: the user's email address.
  • The data should be correctly formatted according to the JSON standards.

How to get started

Open the tasks/json/easy directory from the root of your project.
Then open up the users.json file and once it is properly created according to the JSON syntax, you are done and ready to make a pull request!
Note: You can test your JSON code in a editor like this.


Check out README.md for more instructions and how to make a pull request.

Feel free to ask any questions here if you have some problems!

Also, kindly give this project a star to enhance its visibility for new developers!

@Manudasari265
Copy link

Hi @nikohoffren I'm a beginner and starting on trying out my development skills, can I take up this task.

@nikohoffren
Copy link
Member Author

Hi @nikohoffren I'm a beginner and starting on trying out my development skills, can I take up this task.

Sure! We don't assign anyone to these educational issues, so you are free to start solving the issue right away if you like.

@Manudasari265
Copy link

Okay got it, I made changes and made a compare and pull request did it reflect on your end, if so merge it

@nikohoffren
Copy link
Member Author

Okay got it, I made changes and made a compare and pull request did it reflect on your end, if so merge it

I don't see any pull requests, so something probably went wrong. Are you sure you did everything exactly as in the Submitting changes of the readme, like creating a new branch, adding and commiting the changes and pushing the changes to the same branch etc?

@Manudasari265
Copy link

Ooh I didn't create a new branch I just simply performed git add . , git commit -m "....." after my changes and I did git remote add origin "forked repo URL" and I did git push origin master. Correct me where i went wrong and How can I revert back to it

@nikohoffren
Copy link
Member Author

nikohoffren commented Nov 20, 2023

Ooh I didn't create a new branch I just simply performed git add . , git commit -m "....." after my changes and I did git remote add origin "forked repo URL" and I did git push origin master. Correct me where i went wrong and How can I revert back to it

You can create new branch with git switch -c fix-issue and then make the changes again to the JSON file if they are not there anymore. Then do the git add and git commit as you did before, but remember to push to the new branch with git push origin fix-issue or whatever branch name you are using. The fix-issue is just a name suggestion but it can be anything you want.

HarikaB11 added a commit to HarikaB11/fork-commit-merge that referenced this issue Nov 28, 2023
nikohoffren added a commit that referenced this issue Nov 28, 2023
nikohoffren added a commit that referenced this issue Nov 30, 2023
FIX #1596 added id,username and email to the json file.
@nikohoffren nikohoffren reopened this Nov 30, 2023
nikohoffren added a commit that referenced this issue Dec 2, 2023
22tushar added a commit to 22tushar/fork-commit-merge that referenced this issue Dec 5, 2023
nikohoffren added a commit that referenced this issue Dec 5, 2023
nikohoffren added a commit that referenced this issue Dec 15, 2023
@Vru007
Copy link
Contributor

Vru007 commented Dec 21, 2023

i have made the required changes did it reflect on your side

@nikohoffren
Copy link
Member Author

i have made the required changes did it reflect on your side

Hi! No, i don't see any new pull requests. Make sure to follow the instructions in the README.md carefully.

@Vru007
Copy link
Contributor

Vru007 commented Dec 21, 2023

yeah i have done it now, thanks man for giving push to my open source journey

@nikohoffren
Copy link
Member Author

yeah i have done it now, thanks man for giving push to my open source journey

Thanks for contributing!

@sameer2799
Copy link
Contributor

Hi @nikohoffren, this is my first ever open source contribution. I have created a PR. Please check and do suggest any recommendations.

Thanks.

@nikohoffren
Copy link
Member Author

Hi @nikohoffren, this is my first ever open source contribution. I have created a PR. Please check and do suggest any recommendations.

Thanks.

Hi! Thanks for contributing, PR looked good and is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants