-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork, Commit, Merge - Easy Issue (JSON) #1596
Comments
Hi @nikohoffren I'm a beginner and starting on trying out my development skills, can I take up this task. |
Sure! We don't assign anyone to these educational issues, so you are free to start solving the issue right away if you like. |
Okay got it, I made changes and made a compare and pull request did it reflect on your end, if so merge it |
I don't see any pull requests, so something probably went wrong. Are you sure you did everything exactly as in the Submitting changes of the readme, like creating a new branch, adding and commiting the changes and pushing the changes to the same branch etc? |
Ooh I didn't create a new branch I just simply performed git add . , git commit -m "....." after my changes and I did git remote add origin "forked repo URL" and I did git push origin master. Correct me where i went wrong and How can I revert back to it |
You can create new branch with |
FIX #1596 added id,username and email to the json file.
i have made the required changes did it reflect on your side |
Hi! No, i don't see any new pull requests. Make sure to follow the instructions in the README.md carefully. |
yeah i have done it now, thanks man for giving push to my open source journey |
Thanks for contributing! |
Json Task completed for issue #1596
Hi @nikohoffren, this is my first ever open source contribution. I have created a PR. Please check and do suggest any recommendations. Thanks. |
Hi! Thanks for contributing, PR looked good and is now merged. |
Fork, Commit, Merge - Easy Issue (JSON)
Creating a JSON data file
Note: You don't have ask permission to start solving the issue or get assigned, since these issues are supposed to be always open for new contributors. The actions-user bot will reset the file back to previous state for the next contributor after your commit is merged. So you can just simply start working with the issue right away!
Description:
The goal of this task is to create a JSON file that stores simple data. This will be a list of users where each user has a name, email, and ID.
Acceptance Criteria:
How to get started
Open the
tasks/json/easy
directory from the root of your project.Then open up the
users.json
file and once it is properly created according to the JSON syntax, you are done and ready to make a pull request!Note: You can test your JSON code in a editor like this.
Check out README.md for more instructions and how to make a pull request.
Feel free to ask any questions here if you have some problems!
Also, kindly give this project a star to enhance its visibility for new developers!
The text was updated successfully, but these errors were encountered: