Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Alt+O keyboard shortcut conflict #23

Closed
wjurij opened this issue Oct 31, 2018 · 8 comments
Closed

Ctrl+Alt+O keyboard shortcut conflict #23

wjurij opened this issue Oct 31, 2018 · 8 comments
Milestone

Comments

@wjurij
Copy link

@wjurij wjurij commented Oct 31, 2018

Since version 1.22 there is a shortcut Ctrl+Alt+O assigned to "Open in file explorer", which conflicts with shortcut for a polish letter "ó", which makes it inconvenient to write commit messages in polish.

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Nov 1, 2018

Thank you for reporting the issue.

How is that case handled in other applications?

For example:

  • Ctrl+Alt+O is "Show Output" shortcut in Visual studio
  • Ctrl+Alt+O is "Outline View" in MS Word

It seems that Fork should not handle that shortcut when Commit message field is active. Do you think that will solve the problem?

Loading

@DanPristupov DanPristupov changed the title Keyboard shortcut conflict Ctrl+Alt+O keyboard shortcut conflict Nov 1, 2018
@wjurij
Copy link
Author

@wjurij wjurij commented Nov 2, 2018

Quite interesting, because it seems that despite being assigned, this shortcut just doesnt work neither in VS nor in Word and just inserts the letter.

As far as I remember, there was a similar problem in some graphic card driver software, but it had configurable shortcuts, so it was solveable for the end-user.

Loading

@DanPristupov DanPristupov added this to the 1.30 milestone Mar 20, 2019
@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Mar 22, 2019

In 1.30 I updated the shortcuts to not be fired on AltGr+O

Loading

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Mar 23, 2019

I got the following feedback:

The explorator doesn't open anymore, but looks like typing this character is still blocked. I think you suppress the original event and it still is redirected but now to nowhere.

I'll fix this in the next update.

Loading

@DanPristupov DanPristupov removed this from the 1.30 milestone Mar 23, 2019
@DanPristupov DanPristupov added this to the 1.31 milestone Mar 23, 2019
@wjurij
Copy link
Author

@wjurij wjurij commented Mar 25, 2019

Thank you very much for addressing the issue.

Loading

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Apr 5, 2019

1.31 is out. Please try it.

Loading

@wjurij
Copy link
Author

@wjurij wjurij commented Apr 8, 2019

Now it is working very well. Thank you for resolving this.

Loading

@wjurij wjurij closed this Apr 8, 2019
@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Apr 8, 2019

Finally!

Thank you for your patience :)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants