For mozilla-mobile#16676 - Do not switch mode on last private tab via…

… tab context menu
fork-maintainers · Nov 26, 2020 · d49d710 · d49d710
1 parent 94c59cb
commit d49d710
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarController.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarController.kt
@@ -13,7 +13,6 @@ import org.mozilla.fenix.HomeActivity
 import org.mozilla.fenix.R
 import org.mozilla.fenix.browser.BrowserAnimator.Companion.getToolbarNavOptions
 import org.mozilla.fenix.browser.BrowserFragmentDirections
-import org.mozilla.fenix.browser.browsingmode.BrowsingMode
 import org.mozilla.fenix.browser.readermode.ReaderModeController
 import org.mozilla.fenix.components.metrics.Event
 import org.mozilla.fenix.components.metrics.MetricController
@@ -108,8 +107,6 @@ class DefaultBrowserToolbarController(
                 sessionManager.selectedSession?.let {
                     // When closing the last tab we must show the undo snackbar in the home fragment
                     if (sessionManager.sessionsOfType(it.private).count() == 1) {
-                        // The tab tray always returns to normal mode so do that here too
-                        activity.browsingModeManager.mode = BrowsingMode.Normal
                         homeViewModel.sessionToDelete = it.id
                         navController.navigate(
                             BrowserFragmentDirections.actionGlobalHome()

diff --git a/...src/test/java/org/mozilla/fenix/components/toolbar/DefaultBrowserToolbarControllerTest.kt b/...src/test/java/org/mozilla/fenix/components/toolbar/DefaultBrowserToolbarControllerTest.kt
@@ -208,7 +208,6 @@ class DefaultBrowserToolbarControllerTest {
 
     @Test
     fun handleToolbarCloseTabPressWithLastPrivateSession() {
-        val browsingModeManager = SimpleBrowsingModeManager(BrowsingMode.Private)
         val item = TabCounterMenu.Item.CloseTab
         val sessions = listOf(
             mockk<Session> {
@@ -218,15 +217,13 @@ class DefaultBrowserToolbarControllerTest {
 
         every { currentSession.private } returns true
         every { sessionManager.sessions } returns sessions
-        every { activity.browsingModeManager } returns browsingModeManager
 
         val controller = createController()
         controller.handleTabCounterItemInteraction(item)
         verify {
             homeViewModel.sessionToDelete = "1"
             navController.navigate(BrowserFragmentDirections.actionGlobalHome())
         }
-        assertEquals(BrowsingMode.Normal, browsingModeManager.mode)
     }
 
     @Test