Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real search engine list always when faking the location provider #205

Merged
merged 2 commits into from Oct 4, 2020

Conversation

interfect
Copy link
Collaborator

This should fix #166. I managed to add a custom search engine and it showed up.

Screenshot_20201003-215557_Iceraven_Preview

It also fixes ./gradlew assembleForkDebug.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

The PR runs an Android build check (run-build) that builds a forkRelease variant of the app. If it succeeds, then we upload the apks (signed with debug keys) via Github actions. We also generate a comment with some instructions and a link to help you find the downloads. You can also follow the instructions below:

  1. Click Details next to "run-build (pull_request_target)" after it finishes with a green checkmark.
  2. Click the "Artifacts" drop-down near the top right of the page.
  3. The apk links should be present in the drop-down menu. You can click on the suitable CPU architecture to download a zipped apk file.
  4. Unzip the file and install the apk.

@interfect interfect changed the title Issues/166 allow fallback location Use real search engine list always when faking the location provider Oct 4, 2020
@github-actions
Copy link

github-actions bot commented Oct 4, 2020

Download the built apks

You can download the apks built by Github actions after the CI checks pass.
Please go to the checks page for this PR to find the zipped apk files under the artifacts drop-down, as seen in the example screenshot below.

Note that you will have to click on the "Android build PR" tab on the left side to see the artifacts.

@abhijitvalluri abhijitvalluri merged commit 2f22c97 into fork Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Adding a custom search engine doesn't work
2 participants