Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logo to the new design chosen in the poll #217

Merged
merged 3 commits into from Oct 14, 2020

Conversation

abhijitvalluri
Copy link
Collaborator

@abhijitvalluri abhijitvalluri commented Oct 12, 2020

Updated to the one based on the poll.

Updated the wordmark in the app to use new logo + new font and styling. I think the wordmark graphic overall looks small. So let me know and I can tweak it to make the font and logo in the wordmark in app look bigger.

UPDATE: Made my final tweaks to the wordmark graphic so that the font is a bit bigger and space between logo and text is larger.

Screenshots (dark and light theme)



Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

The PR runs an Android build check (run-build) that builds a forkRelease variant of the app. If it succeeds, then we upload the apks (signed with debug keys) via Github actions. We also generate a comment with some instructions and a link to help you find the downloads. You can also follow the instructions below:

  1. Click Details next to "run-build (pull_request_target)" after it finishes with a green checkmark.
  2. Click the "Artifacts" drop-down near the top right of the page.
  3. The apk links should be present in the drop-down menu. You can click on the suitable CPU architecture to download a zipped apk file.
  4. Unzip the file and install the apk.

@abhijitvalluri
Copy link
Collaborator Author

abhijitvalluri commented Oct 12, 2020

@interfect how is this? Ignore the flaky signing issues in the CI causing failures. Fixed failing signing. Frustrating but signing won't work properly for PRs from forks.

Copy link
Collaborator

@interfect interfect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for putting this in everywhere.

@interfect interfect merged commit c769d5a into fork-maintainers:fork Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants