Added new Release Version #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no message
Craft CMS automatically appends the preview ?token= query param to
all element URLs. This could result in the cache being poisoned by
preview URLs.
Steps to reproduce:
- Have a transformer that provides getCacheKey and retrieves an
element URL
- Ensure that the cache is empty, e.g. run ./craft clear-caches/all
- Open a preview in the CMS that triggers the transformer
- Open the page without preview token in an incognito tab
- The URL retrieved by the transformer now has an unexpected preview
token
Preview tokens should NOT be cached as they disable page caching and
may expose content to public visitors that they should not have seen.
This commit adapts the behavior of the {% cache %} twig tag:
https://github.com/craftcms/cms/blob/c21a32ea8f9f3ded626e07c36c85ab0da2379b22/src/web/twig/nodes/CacheNode.php#L48
fix: Ignore cache when in CMS preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.