Module Blog. Wrong premoderation algorithm for comments.

[Sellato]

Type

• Non critical bug

Problem description

If premoderation option enabled, premoderation algorithm works at this time like this:

1. User post a comment
2. Post is published
3. Admin can mark a post as "premoderated"

I think this is wrong.

The right algorithm should be:

1. User post a comment
2. Post is market as premoderated and don't published
3. Admin get a message and decide publish or not this comment

Steps to reproduce

post a comment at demo site http://demo.fork-cms.com/

Expected behavior / Proposed solutions

Mark all new posts as premoderated by default if "premoderation" option is enabled.

[carakas]

Your description of the current algorithm is incorrect.

if ($this->isModerationFilterEnabled()
    && !FrontendBlogModel::isModerated($comment['author'], $comment['email'])) {
    $comment['status'] = 'moderation';
}

1. User posts a comment for the first time
2. Post is marked as in moderation
3. Admin marks post as published
4. User posts a comment for the second time
5. User has already been approved once so the post is published to lighten the load of the admin

Maybe we need an extra setting that toggles whether step 5 should be enabled or not

[Sellato]

it seems that this is not working :(

Post is marked as in moderation

Premoderation is enabled:

There is 2 comments in current blog post:

I add my comment and it posted immediately without moderation

[carakas]

@Sellato there was a bug indeed :) It will be fixed in the next release :) Moderation only worked when the spamfilter was enabled