New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

special character escaping in parameters.yml by installer #477

Closed

DoFken opened this issue Apr 23, 2013 · 1 comment

Labels

Bug

Contributor

DoFken commented Apr 23, 2013

The installer will fill the parameters in step 7 in the parameters.yml file, but @actiongroup should be escaped as @@actiongroup

If the getConfigurationVariables will only by used for this it could be changed at https://github.com/forkcms/forkcms/blob/master/install/engine/step_7.php#L282 to @@actiongroup

Otherwise, all special characters in the variables should be escaped here: https://github.com/forkcms/forkcms/blob/master/install/engine/step_7.php#L107

Contributor

dieterve commented Jul 30, 2013

When do you get an error? I am guessing we should add double quotes around the strings here: https://github.com/forkcms/forkcms/blob/master/install/engine/step_6.php#L137 ?

davelens closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment