Check token correctly #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use `$this->getField('form_token')->getValue();` it will use the field
that is automagically added, instead of the real submitted value.
carakas
requested changes
Dec 16, 2020
spoon/form/form.php
Outdated
| if ($this->getMethod() === 'get' && !isset($_GET['form_token']) | ||
| || $this->getMethod() === 'post' && !isset($_POST['form_token'])) { | ||
| $submittedToken = ''; | ||
| if ($this->getMethod() === 'get' && !isset($_GET['form_token']) { |
There was a problem hiding this comment.
i think there is still something wrong here. You are checking if the method is get and if there isn't a form token in $_GET. If that is the case you try to get the not existing token out of $_GET.
The same happens with $_POST
There was a problem hiding this comment.
You also forgot to close a ) here and with the post one
carakas
requested changes
Dec 16, 2020
spoon/form/form.php
Outdated
| if ($this->getMethod() === 'get' && !isset($_GET['form_token']) | ||
| || $this->getMethod() === 'post' && !isset($_POST['form_token'])) { | ||
| $submittedToken = ''; | ||
| if ($this->getMethod() === 'get' && !isset($_GET['form_token']) { |
There was a problem hiding this comment.
You also forgot to close a ) here and with the post one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix only fixed checking if the token was submitted.
Further on in the code the submitted value was not used, instead the value of the automagically added field was used. Which made the check useless as it will alway be the same...